Skip to content

Add missing device id for pytorch 2.8 #21105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 1, 2025
Merged

Add missing device id for pytorch 2.8 #21105

merged 18 commits into from
Sep 1, 2025

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Aug 21, 2025 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #21095

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21105.org.readthedocs.build/en/21105/

@SkafteNicki SkafteNicki self-assigned this Aug 21, 2025
@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Aug 21, 2025
Borda
Borda reviewed Aug 21, 2025
View reviewed changes
Copy link
Contributor

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have atest for it?

deependujha
deependujha approved these changes Aug 30, 2025
View reviewed changes
Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I've tested the changes on a T4 machine with 4 GPUs, and the code ran successfully. I can confirm that the original warning is no longer present.

@deependujha deependujha force-pushed the torch_28_add_missing_device_id branch from cb51fd4 to b1a7e1c Compare September 1, 2025 07:01
@codecov Codecov
Copy link

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (2e4c99c) to head (a8b8948).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #21105   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         269      269           
  Lines       23541    23560   +19     
=======================================
+ Hits        20528    20543   +15     
- Misses       3013     3017    +4

Borda
Borda reviewed Sep 1, 2025
View reviewed changes
Borda
Borda reviewed Sep 1, 2025
View reviewed changes
Borda
Borda reviewed Sep 1, 2025
View reviewed changes
Borda
Borda reviewed Sep 1, 2025
View reviewed changes
Borda
Borda reviewed Sep 1, 2025
View reviewed changes
Borda
Borda reviewed Sep 1, 2025
View reviewed changes
@Borda Borda merged commit 6fc44c9 into Lightning-AI:master Sep 1, 2025
147 of 150 checks passed
Borda added a commit that referenced this pull request Sep 3, 2025
@SkafteNicki @Borda
@deependujha @pre-commit-ci
Add missing device id for pytorch 2.8 (#21105)
8f8ed37 
* add missing device id for pytorch 2.8
* skip device id for older pytorch versions
* add testing
* fix mypy without touching submodule
* fix failing tests
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Deependu <[email protected]>
Co-authored-by: Jirka B <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 6fc44c9)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
@SkafteNicki @Borda
@deependujha @pre-commit-ci @lantiga
Add missing device id for pytorch 2.8 (#21105)
ba4cc1d 
* add missing device id for pytorch 2.8
* skip device id for older pytorch versions
* add testing
* fix mypy without touching submodule
* fix failing tests
* Apply suggestions from code review

---------

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Deependu <[email protected]>
Co-authored-by: Jirka B <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 6fc44c9)
@SkafteNicki SkafteNicki mentioned this pull request Sep 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock justusschock approved these changes

@deependujha deependujha deependujha approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

@SkafteNicki SkafteNicki

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UserWarning: No device id is provided

4 participants

@SkafteNicki @Borda @justusschock @deependujha